Re: Hard-coded PUBLIC in pg_dump

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)apb(dot)com(dot)tr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Hard-coded PUBLIC in pg_dump
Date: 2002-12-01 18:44:06
Message-ID: 200212011844.gB1Ii7b14487@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-advocacy pgsql-general pgsql-hackers

Tom Lane wrote:
> If the parser treated PUBLIC as an actual keyword, you'd not be having
> this problem, because keywords are case-folded on an ASCII-only basis
> (which is consistent with the SQL99 spec, amazingly enough).
>
> We put in the above hack after someone complained that PUBLIC didn't use
> to be a reserved word ... but considering that SQL92 clearly lists it as
> a reserved word, there's not a lot of ground for that complaint to stand
> on.
>
> I'd prefer shifting PUBLIC back to the true-keyword category over any
> of the other workarounds you've suggested ...

PUBLIC doesn't seem like a very common column name --- seems safe to
make it reserved. We made 'value' reserved in 7.3, and that was a much
more common one.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-advocacy by date

  From Date Subject
Next Message Tom Lane 2002-12-01 18:49:30 Re: Hard-coded PUBLIC in pg_dump
Previous Message Stephan Szabo 2002-12-01 17:53:55 Re: 7.4 Wishlist

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2002-12-01 18:49:30 Re: Hard-coded PUBLIC in pg_dump
Previous Message Taz Master 2002-12-01 18:17:35 Inserting large number of rows using libpq++ stops responding in c++

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-12-01 18:49:30 Re: Hard-coded PUBLIC in pg_dump
Previous Message Stephan Szabo 2002-12-01 17:53:55 Re: 7.4 Wishlist