Re: move 0 behaviour

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Dave Cramer <dave(at)fastcrypt(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: move 0 behaviour
Date: 2002-11-02 03:14:56
Message-ID: 200211020314.gA23EuN07245@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers pgsql-jdbc

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > The following patch makes FETCH/MOVE 0 do nothing, and FETCH LAST move
> > to the end.
>
> Do not hack up PerformPortalFetch; put the special case for INT_MAX in
> utility.c's FetchStmt code, instead. As-is, you probably broke other
> callers of PerformPortalFetch.

I thought about that, but I need to fail if the cursor name is invalid.
Those tests are done in PerformPortalFetch(). The good news is that no
one else call it. Other ideas?

> BTW, there's a comment in parsenodes.h that needs to be fixed too:
>
> int howMany; /* amount to fetch ("ALL" --> 0) */

Done.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Bruce Momjian 2002-11-02 03:18:44 Re: CREATE TABLE oddity?
Previous Message Tom Lane 2002-11-02 03:03:17 Re: Cursors: getting the number of tuples; moving backwards

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-11-02 03:28:36 Re: elog(PANIC) should abort()?
Previous Message Tom Lane 2002-11-02 03:03:17 Re: Cursors: getting the number of tuples; moving backwards

Browse pgsql-jdbc by date

  From Date Subject
Next Message Tom Lane 2002-11-02 04:49:32 Re: move 0 behaviour
Previous Message Tom Lane 2002-11-02 03:03:17 Re: Cursors: getting the number of tuples; moving backwards