| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql-server/src backend/rewrite/rewriteHandle ... |
| Date: | 2002-10-20 00:58:55 |
| Message-ID: | 20021020005855.8BAF3475E18@postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl(at)postgresql(dot)org 02/10/19 20:58:55
Modified files:
src/backend/rewrite: rewriteHandler.c rewriteManip.c
src/include/rewrite: rewriteManip.h
Log message:
Rule rewriter was doing the wrong thing with conditional INSTEAD rules
whose conditions might yield NULL. The negated qual to attach to the
original query is properly 'x IS NOT TRUE', not 'NOT x'. This fix
produces correct behavior, but we may be taking a performance hit because
the planner is much stupider about IS NOT TRUE than it is about NOT
clauses. Future TODO: teach prepqual, other parts of planner how to
cope with BooleanTest clauses more effectively.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-10-20 01:38:18 | pgsql-server/doc/src/sgml installation.sgml |
| Previous Message | Tom Lane | 2002-10-20 00:31:53 | pgsql-server/src/backend/parser analyze.c |