Re: pgsql-server/src/backend executor/nodeAgg.c ut ...

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src/backend executor/nodeAgg.c ut ...
Date: 2002-10-04 17:36:38
Message-ID: 200210041736.g94HacG25944@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> CVSROOT: /cvsroot
> Module name: pgsql-server
> Changes by: tgl(at)postgresql(dot)org 02/10/04 13:19:55
>
> Modified files:
> src/backend/executor: nodeAgg.c
> src/backend/utils/fmgr: fmgr.c
> src/backend/utils/sort: tuplesort.c
>
> Log message:
> Tweak a few of the most heavily used function call points to zero out
> just the significant fields of FunctionCallInfoData, rather than MemSet'ing
> the whole struct to zero. Unused positions in the arg[] array will
> thereby contain garbage rather than zeroes. This buys back some of the
> performance hit from increasing FUNC_MAX_ARGS. Also tweak tuplesort.c
> code for more speed by marking some routines 'inline'. All together
> these changes speed up simple sorts, like count(distinct int4column),
> by about 25% on a P4 running RH Linux 7.2.

Wow, huge win. Thanks, Tom.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Neil Conway 2002-10-04 18:12:53 Re: pgsql-server/src/backend executor/nodeAgg.c ut ...
Previous Message Tom Lane 2002-10-04 17:34:03 pgsql-server/src/backend/utils/adt nabstime.c