Re: Please rename split(text,text,int) to splitpart

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hannu Krosing <hannu(at)tm(dot)ee>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Please rename split(text,text,int) to splitpart
Date: 2002-09-11 04:42:16
Message-ID: 200209110442.g8B4gGr16111@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am not either. How do you do the documentation when the function can
> > be called two ways.
>
> You don't. There is only one supported name, so that's the only one
> you document.
>
> > I guess we can give the SQL query to fix it during
> > beta2 _and_ add a regression test to make sure it is fix. That sounds
> > like a plan.
>
> That sounds like massive overkill. Just apply the patch. We don't need
> to institutionalize a regression test for this.

It would catch people who don't apply the patch. We could remove the
test after 7.3. Just an idea.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-09-11 04:45:06 Re: 7.3beta and ecpg
Previous Message Tom Lane 2002-09-11 04:40:07 Re: Please rename split(text,text,int) to splitpart

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2002-09-11 05:05:45 Re: Please rename split(text,text,int) to splitpart
Previous Message Tom Lane 2002-09-11 04:40:07 Re: Please rename split(text,text,int) to splitpart