Re: cube and earthdistance diffs

From: Bruno Wolff III <bruno(at)wolff(dot)to>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: cube and earthdistance diffs
Date: 2002-09-10 02:53:03
Message-ID: 20020910025303.GA17737@wolff.to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, Sep 09, 2002 at 22:16:06 -0400,
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> Bruno Wolff III wrote:
> > Reading a message in another thread makes it seem likely that I am going
> > to want to change things to add the grants into the creation scripts,
> > so I will probably need to change thinsg anyway and might as well fix
> > the cube install issues myself.
>
> Actually, I though that to make earthdistance, you were going to specify
> cube/* as a dependency, and have that compile before earthdistance
> compiled. Maybe that would work, but earthdistance can't install cube.

No big deal. I sent in a new patch that doesn't install cube, but instead
says to install it first in the documentation.

It isn't like the psql using libpq case, because it needs the functions to
be loadable into the database to run the regression test. The real dependency
was that to usefully install earthdistance you needed to have cube installed.
I didn't need to have it to the install on all, to it would have to be
installed to run the regression test.

I also got a regression test failure reported to me this evening on an alpha
and it turns out the was a bug in cube_enlarge that didn't cause a
regression failure on my system by luck. I submitted a patch for it tonight.
It doesn't touch anything changed by my other patch and can be applied
either before or after the other one. I also changed a couple of ints to
int4s to match the sql declarations used for the functions.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruno Wolff III 2002-09-10 03:36:54 Re: Fix for cube bug
Previous Message Bruno Wolff III 2002-09-10 02:44:06 Fix for cube bug