Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?
Date: 2002-08-28 14:25:56
Message-ID: 200208281425.g7SEPuM14920@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-sql

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Larry Rosenman wrote:
> >> Why? If both old and new are acceptable, why not document it?
> >> (Just curious, I'm not wedded to it).
>
> > Well, showing both versions adds confusion for no good reason,
>
> Yes, particularly considering that LIMIT ... FOR UPDATE corresponds
> to the implementation behavior (LIMIT acts before FOR UPDATE) while
> FOR UPDATE ... LIMIT does not.
>
> I concur with documenting only the preferred form (though there should
> be a note in gram.y explaining that we're supporting the old syntax
> for backward compatibility).

I originally thought the grammar would be ugly to support both, but in
fact it has almost the same number of actions as before, so we can keep
it around for a while if not forever.

I will update the gram.y comments to indicate it will live beyond 7.3.X.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-28 14:26:53 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?
Previous Message Robert Treat 2002-08-28 14:24:11 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

Browse pgsql-sql by date

  From Date Subject
Next Message Bruce Momjian 2002-08-28 14:26:53 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?
Previous Message Robert Treat 2002-08-28 14:24:11 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?