| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: bug in COPY |
| Date: | 2002-08-27 19:58:36 |
| Message-ID: | 200208271958.g7RJwac02983@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > else if (*s == 0)
> > ! elog(ERROR, "pg_atoi: zero-length string!");
>
> The exclamation point seems inappropriate. Perhaps "zero-length input"
> would be better than "string" also.
I copied the other test case:
if (s == (char *) NULL)
elog(ERROR, "pg_atoi: NULL pointer!");
I removed them both '!'.
> Otherwise this seems like a reasonable thing to do.
OK, will apply now.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lamar Owen | 2002-08-27 20:05:36 | Re: Open 7.3 items |
| Previous Message | Tom Lane | 2002-08-27 19:55:15 | Re: bug in COPY |