Re: @(#)Mordred Labs advisory 0x0003: Buffer overflow in PostgreSQL

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vince Vielhaber <vev(at)michvhf(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: @(#)Mordred Labs advisory 0x0003: Buffer overflow in PostgreSQL
Date: 2002-08-21 17:22:13
Message-ID: 200208211722.g7LHMD828912@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Neil Conway wrote:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> > Neil Conway <neilc(at)samurai(dot)com> writes:
> > > + /* Check for integer overflow */
> > > + if (tlen / slen != count)
> > > + elog(ERROR, "Requested buffer is too large.");
> >
> > What about slen == 0?
>
> Good point -- that wouldn't cause incorrect results or a security
> problem, but it would reject input that we should really accept.
>
> Revised patch is attached.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-21 17:24:24 Re: [HACKERS] [GENERAL] workaround for lack of REPLACE()
Previous Message Zeugswetter Andreas SB SD 2002-08-21 17:18:46 Re: @(#) Mordred Labs advisory 0x0001: Buffer overflow in