Re: clean up assertion code

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: clean up assertion code
Date: 2002-08-10 20:50:59
Message-ID: 200208102050.g7AKox823576@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


I am running my standard post-patch application test to make sure the
files in my directory tree exactly match CVS, and I now see that CVS
re-added these two files:

U pgsql/src/include/utils/exc.h
U pgsql/src/include/utils/excid.h

Files removed. Seems 'patch' properly removes the file but CVS of
course doesn't. They have to be manually removed.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Actually, CVS did properly remove the files. The only problem was that
> > the src/backend/utils/error/*.c files were specified backwards in the
> > patch. The include/utils/*.h files removed automatically.
>
> Oh? Your commit message doesn't show that they went away...
> it looks to me like three out of the six files Neil wanted to zap
> are still with us.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-08-10 21:03:41 Re: CLUSTER patch and regression test
Previous Message Bruce Momjian 2002-08-10 20:44:52 Re: anonymous composite types