Re: [COMMITTERS] pgsql-server/src backend/tcop/postgres.c backe ...

Thomas Lockhart wrote:
> CVSROOT: /cvsroot
> Module name: pgsql-server
> Changes by: thomas(at)postgresql(dot)org 02/08/04 02:26:38
>
> Modified files:
> src/backend/tcop: postgres.c
> src/backend/bootstrap: bootstrap.c
> src/backend/postmaster: postmaster.c
> src/bin/initdb : initdb.sh
> src/bin/pg_ctl : pg_ctl.sh
> src/include/access: xlog.h
>
> Log message:
> Implement WAL log location control using "-X" or PGXLOG.

Woh, I didn't think we had agreement on this. This populates the 'X'
all over the system (postgres, postmaster, initdb, pg_ctl), while the
simple solution would be to add the flag only to initdb and use a
symlink from /data. I also think it is less error-prone because you
can't accidentally point to the wrong XLOG directory. In fact, you
almost have to use an environment variable unles you plan to specify -X
for all the commands. In my mind, PGDATA should take care of the whole
thing for pointing to your data.

If you want to do it this way, I request a vote.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026