Re: [GENERAL] Stats Collector

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Jan Wieck <JanWieck(at)Yahoo(dot)com>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] Stats Collector
Date: 2002-07-30 22:33:37
Message-ID: 200207302233.g6UMXbL05689@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> I don't like SET for it --- SET is for setting state that will persist
> >> over some period of time, not for taking one-shot actions. We could
> >> perhaps use a function that checks that it's been called by the
> >> superuser.
>
> > Should we have RESET clear the counter, perhaps RESET STATCOLLECTOR?
> > I don't think we have other RESET variables that can't be SET, but I
> > don't see a problem with it.
>
> RESET is just a variant form of SET. It's not for one-shot actions
> either (and especially not for one-shot actions against state that's
> not accessible to SHOW or SET...)
>
> I still like the function-call approach better.

OK, so you are suggesting a function call, and a check in there to make
sure it is the superuser. Comments?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Rob Brown-Bayliss 2002-07-30 22:46:24 Re: Questions about my strategy
Previous Message Joey Gartin 2002-07-30 22:28:03 Client Admin Tools

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Lockhart 2002-07-30 22:50:12 Re: WAL file location
Previous Message Bruce Momjian 2002-07-30 22:32:18 Re: START TRANSACTION