Re: several minor cleanups

OK, I have applied this patch, except for the changes that effect the
elog messages. I will have to take a poll on general before I can make
those changes.

Thanks.

---------------------------------------------------------------------------

Neil Conway wrote:
> On Mon, Jun 24, 2002 at 04:53:17PM -0400, Tom Lane wrote:
> > Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> writes:
> > ***************
> > *** 251,257 ****
> > ExecCheckRTPerms(parseTree->rtable, operation);
> >
> > /*
> > ! * Search for subplans and APPEND nodes to check their rangetables.
> > */
> > ExecCheckPlanPerms(plan, parseTree->rtable, operation);
> > }
> > --- 251,257 ----
> > ExecCheckRTPerms(parseTree->rtable, operation);
> >
> > /*
> > ! * Search for subplans and INSERT nodes to check their rangetables.
> > */
> > ExecCheckPlanPerms(plan, parseTree->rtable, operation);
> > }
> > ***************
> >
> > This comment was right beforehand and is so no longer :-(.
>
> Woops, s/append/insert/g was a bit over-enthusiastic. A revised
> patch is attached (it's also updated for CVS HEAD).
>
> > Otherwise I'm okay with this, if we don't mind the probability of
> > breaking existing client applications that are looking for ExecAppend:
> > messages.
>
> I would be skeptical of any client application that tries to
> divine information about the result of an operation by inspecting
> error messages. IMHO, such an approach is hopelessly fragile
> without error codes (or at least a well-defined set of
> possible errors for a given query).

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026