Global Variables (Was: Re: Discontent with development process (was:Re: pgaccess - the discussion is over) )

From: "Marc G(dot) Fournier" <scrappy(at)hub(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jan Wieck <janwieck(at)yahoo(dot)com>, Lamar Owen <lamar(dot)owen(at)wgcr(dot)org>, mlw <markw(at)mohawksoft(dot)com>, Iavor Raytchev <iavor(dot)raytchev(at)verysmall(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Global Variables (Was: Re: Discontent with development process (was:Re: pgaccess - the discussion is over) )
Date: 2002-05-14 16:29:23
Message-ID: 20020514132728.U75064-100000@mail1.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-interfaces

Mark (mlw) ... could you generate a listing of those variables you feel
would need to be moved to a 'global structure' and post that to the list?
That would at least give us a starting point, instead of both sides
guessing at what is/would be involved ...

On Tue, 14 May 2002, Tom Lane wrote:

> Jan Wieck <janwieck(at)yahoo(dot)com> writes:
> > As I understood it the idea was to put the stuff, the
> > backends inherit from the postmaster, into a centralized
> > place, instead of having it spread out all over the place.
> > What's wrong with that?
>
> The main objection to it in my mind is that what had been private
> variables in specific modules now become exceedingly public. Instead of
> looking at "static int foo" and *knowing* that all the references are in
> the current file, you have to go trolling the entire backend to see who
> is referencing pg_globals.foo.
>
> I have not counted to see how many variables are really affected; if
> there's only a few then it doesn't matter much. But the people who
> have done this so far have all reported inserting tons of #ifdefs,
> which leads me to the assumption that there's a lot of 'em.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-05-14 17:04:23 Final(?) proposal on GUC hook extensions
Previous Message Myron Scott 2002-05-14 16:17:58 Re: Discontent with development process (was:Re: pgaccess - the discussion is over)

Browse pgsql-interfaces by date

  From Date Subject
Next Message mlw 2002-05-14 17:55:19 Re: Global Variables (Was: Re: Discontent with development
Previous Message Myron Scott 2002-05-14 16:17:58 Re: Discontent with development process (was:Re: pgaccess - the discussion is over)