Re: pg_dump DROP commands and implicit search paths

From: nconway(at)klamath(dot)dyndns(dot)org (Neil Conway)
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: pg_dump DROP commands and implicit search paths
Date: 2002-05-14 00:33:58
Message-ID: 20020514003358.GB9490@klamath.dyndns.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 13, 2002 at 02:58:08PM -0400, Tom Lane wrote:
> 1. Explicitly qualify target-object names in the DROP commands,

> 2. Modify the backend so that DROP has a different behavior from
> other commands

> Choice #1 is logically cleaner but would clutter the dump script with
> many more explicit schema references than I'd like to have.

I'd prefer this method -- IMHO the readibility of dump scripts isn't
a top priority (or if it is, we're not doing very well in that regard
any). I think dump scripts should be as verbose as is necessary to
ensure that they can't be misinterpreted.

> Choice #2 is awfully ugly at first glance but might prove a good
> idea in the long run.

It's certainly ugly, and I'm skeptical as to its long term benefits
(I would think that the cleaner solution would be more maintainable
in the long run). Am I missing something?

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Inoue 2002-05-14 00:34:59 What's the meaning of system column in views
Previous Message Rod Taylor 2002-05-14 00:31:31 Re: TRUNCATE