Re: numeric/decimal docs bug?

From: Jan Wieck <janwieck(at)yahoo(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Jan Wieck <janwieck(at)yahoo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, Jan Wieck <JanWieck(at)yahoo(dot)com>
Subject: Re: numeric/decimal docs bug?
Date: 2002-04-13 16:50:22
Message-ID: 200204131650.g3DGoMs08607@saturn.janwieck.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Christopher Kings-Lynne wrote:
> > > Having seen zero reports of any numeric
> > > failures since we installed it, and seeing it takes >10x times longer
> > > than the other tests, I think it should be paired back. Do we really
> > > need 10 tests of each complex function? I think one would do the trick.
> >
> > A good point tho, I didn't submit a regression test that tries to ALTER 3
> > different non-existent tables to check for failures - one test was enough...
>
> That was my point. Is there much value in testing each function ten
> times. Anyway, seems only I care so I will drop it.

Yes there is value in it. There is conditional code in it
that depends on the values. I wrote that before (I said there
are possible carry, rounding etc. issues), and it looked to
me that you simply ignored these facts.

Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2002-04-13 18:35:39 Re: 7.3 schedule
Previous Message Hannu Krosing 2002-04-13 16:47:07 Re: DROP COLUMN (was RFC: Restructuring pg_aggregate)