Re: elog() patch

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > However, with DEBUG symbol gone, or at least gone after 7.3, I don't see
> > a big need to add PG_ to the beginning of every elog() symbol. Can I
> > get some votes on that? DEBUG was our big culprit of conflict with
> > other interfaces, specifically Perl.
>
> Wrong: ERROR is a problem too. And if you think that INFO or WARNING
> or PANIC will not create new problems, you are a hopeless optimist.
>
> We are already forcing renamings of a lot of elog symbols (eg, NOTICE
> and DEBUG), so we may as well go the extra step and actually solve the
> problem, rather than continue to ignore it.
>
> BTW, I'd go with PGERROR etc, not PG_ERROR, just to save typing.

OK, unless someone else responds, we will go with PG* and
NOTICE->WARNING near 7.3 beta start when tree is quiet. We will keep
old symbols around for 7.3 release.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026