Re: elog() proposal

From: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: elog() proposal
Date: 2002-02-21 09:06:22
Message-ID: 20020221100622.A21620@zf.jcu.cz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 20, 2002 at 09:54:51PM -0500, Bruce Momjian wrote:
> I just submitted a patch to fix various elog() issues. I have two
> additional proposals.
>
> First, I think ERROR/DEBUG/NOTICE/FATAL, etc are too generic and cause
> compile problems/warnings, especially with Perl. I suggest renaming all
> elog levels to PG*, so it would be PGERROR and PGINFO. We could also do
> E_* or E*. I am interested in other opinions.

You forgot PG_* :-)

> Second, I propose adding two GUC variables that control how much elog()
> info is sent to the server and client logs. I suggest
> 'server_message_min' with possible values DEBUG, LOG, NOTICE, ERROR,
> FATAL, CRASH; and 'client_message_min' with possible values INFO,
> NOTICE, ERROR, FATAL, CRASH.

IMHO stop an example NOTICE by "SET NOTICE TO 'OFF'" is better and
more common way than current the only one way in libpq and
PQsetNoticeProcessor.

Karel

--
Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
http://home.zf.jcu.cz/~zakkr/

C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jean-Michel POURE 2002-02-21 09:13:23 Re: UTF-8 data migration problem in Postgresql 7.2
Previous Message Turbo Fredriksson 2002-02-21 08:58:53 Error with a SQL query 'between .. and .. and'