Re: [SQL] Unpredictable text -> date implicit casting behaviour/to_date

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aasmund Midttun Godal <postgresql(at)envisity(dot)com>
Subject: Re: [SQL] Unpredictable text -> date implicit casting behaviour/to_date
Date: 2002-01-02 18:26:31
Message-ID: 200201021826.g02IQVa10644@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-sql


Thomas added datetime stuff over the weekend, so I assume this patch
should be applied in the next 24 hours, unless someone objects.

---------------------------------------------------------------------------

Karel Zak wrote:
> On Mon, Dec 31, 2001 at 11:02:47AM -0500, Tom Lane wrote:
> > "Aasmund Midttun Godal" <postgresql(at)envisity(dot)com> writes:
> > > The implicit casting of text to date is normally quite good, however i
> > > think it should only use one method during a given query (or maybe
> > > transaction?)
> >
> > Try setting DateStyle to match the date style you are using. Postgres
> > is doing the best it can with ambiguous input.
> >
> > > Added to the fact that to_date has a bug:
> >
> > > SELECT ordredato, ordredato::date, to_date(ordredato, 'DD.MM.YY') from old_faktura where status = 'ANN';
> > > ordredato | ?column? | to_date
> > > -----------+------------+---------------
> > > 18.04.00 | 2000-04-18 | 0001-04-18 BC
> > > 30.08.01 | 2001-08-30 | 2001-08-30
> > > 18.04.00 | 2000-04-18 | 0001-04-18 BC
> >
> > I agree, this is not desired behavior. The problem seems to be that the
> > logic in to_timestamp() tries to use "field is not zero" as a substitute
> > test for "field was provided". At least in the case of the year fields,
> > this is *not* workable. There must be a separate flag bit.
> >
> > regards, tom lane
>
> Nice bug :-(
>
> It's fixed and the patch is attached, please apply it to 7.2.
>
> Thanks for report.
>
> Karel
>
> --
> Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
> http://home.zf.jcu.cz/~zakkr/
>
> C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-01-02 22:10:29 Re: [SQL] Unpredictable text -> date implicit casting behaviour/to_date bug
Previous Message Karel Zak 2002-01-02 13:04:07 Re: [SQL] Unpredictable text -> date implicit casting behaviour/to_date bug

Browse pgsql-sql by date

  From Date Subject
Next Message Josh Berkus 2002-01-02 19:38:28 Re: Tree structure index usage
Previous Message Alex Glikson 2002-01-02 13:31:00 OUTER JOIN doesn't work on pgSQL 7.1.2