Re: The dbase conrtib doesn't compile

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Yes, glad you pointed it out. I think the best solution is to remove
> > #define HAVE_ICONV_H and -liconv so it will work fine on all platforms.
> > If someone wants the iconv conversions, they can add the needed #define
> > and link library, OK?
>
> That seems like a plan. Perhaps add some commented-out macro
> definitions to the makefile to make it a simple addition. Something
> like
>
> # Uncomment this to provide charset translation
> # CFLAGS += -DHAVE_ICONV_H
> # You might need to uncomment this too, if libiconv is a separate
> # library on your platform
> # LIBS += -liconv
>
> Untested but you get the idea ...

OK, patch attached and applied. I tested with and without the Makefile
defines. iconv defaults to off, mentioned in README.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026