Re: The dbase conrtib doesn't compile

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The dbase conrtib doesn't compile
Date: 2001-12-21 04:12:44
Message-ID: 200112210412.fBL4CiA25407@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> In HEAD contrib/dbase:
>
> gcc -pipe -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -I../../src/
> interf
> aces/libpq -I. -I../../src/include -c -o dbf2pg.o dbf2pg.c
> dbf2pg.c:19: iconv.h: No such file or directory
> dbf2pg.c:38: syntax error before `iconv_d'
> dbf2pg.c:38: warning: type defaults to `int' in declaration of `iconv_d'
> dbf2pg.c:38: warning: data definition has no type or storage class
> dbf2pg.c: In function `convert_charset':
> dbf2pg.c:148: warning: implicit declaration of function `iconv'
> dbf2pg.c: In function `main':
> dbf2pg.c:789: warning: implicit declaration of function `iconv_open'
> dbf2pg.c:790: `iconv_t' undeclared (first use in this function)
> dbf2pg.c:790: (Each undeclared identifier is reported only once
> dbf2pg.c:790: for each function it appears in.)
> dbf2pg.c:810: warning: implicit declaration of function `iconv_close'
> gmake: *** [dbf2pg.o] Error 1

Yes, I am seeing the same failure here. I knew there was a /contrib
module that needed iconv but I can't find it now. I suppose this was
the one.

I see the old Makefile used iconv:

! $(CC) $(CFLAGS) $(OBJS) $(libpq) $(LDFLAGS) $(LIBS) -liconv -o $@

but the overhaul of these Makefiles on 2001/09/06 removed it. I am
applying the following patch to re-add it. You will need libiconv for
it to link.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 1.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2001-12-21 04:13:57 Re: The dbase conrtib doesn't compile
Previous Message Bruce Momjian 2001-12-21 04:03:53 Re: contrib idea