Re: Fix for 'extern "C"' indenting

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix for 'extern "C"' indenting
Date: 2001-11-08 20:41:43
Message-ID: 200111082041.fA8Kfi822765@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Attached is a patch which is a run of an improved pgindent over several
> > include files that contained 'extern "C"' blocks.
> > Do people want this applied or should we just live with a ugly indenting
> > of a few C files for 7.2?
>
> I'd say go for it ... particularly if you already committed the
> corresponding pgindent fix. It would be weird to ship a pgindent
> that doesn't agree with the formatted files.

Done. FYI, pgindent sometimes doesn't match what we ship because I
tweek it for the _next_ run, which may not happen for 6-9 months.

The interesting case with 'extern "C"' is that pgindent was properly
indenting the block, but in this case, it just made no sense. It also
thought it was in some kind of function and didn't understand certain
prototypes.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-11-09 00:44:44 Call for objections: revision of keyword classification
Previous Message Bruce Momjian 2001-11-08 20:05:54 [PATCHES] MD5 support for ODBC