From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Joe Conway <joseph(dot)conway(at)home(dot)com> |
Cc: | "pgsql-patches(at)postgresql(dot)org" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: contrib/fuzzystrmatch |
Date: | 2001-10-29 19:41:37 |
Message-ID: | 200110291941.f9TJfbT14561@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
OK, I see your patch but it appears to just move a blank line to below
the macro and it shows two calls to End_Phoned_Word while I see only one
in the file. I am sure this was some kind of cut/paste wrapping
problem in the email.
I applied the following patch which does what I think you intended,
which is to add a trailing semicolon. This is very common because
incorrectly structured macro allowed the old syntax while the correct
macro does not.
Thanks.
---------------------------------------------------------------------------
> Here's a trivial patch for fuzzystrmatch.c (broken due to macro cleanup).
>
> -- Joe
>
>
> --- fuzzystrmatch.c.orig Sun Oct 28 22:45:46 2001
> +++ fuzzystrmatch.c Sun Oct 28 22:42:54 2001
> @@ -341,7 +341,7 @@
> /* On the off chance we were given nothing but crap... */
> if (Curr_Letter == '\0')
> {
> - End_Phoned_Word
> + End_Phoned_Word;
>
> return META_SUCCESS; /* For testing */
> }
> }
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 764 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Serguei Mokhov | 2001-10-29 23:09:34 | Re: Add regression test for ALTER TABLE / ADD UNIQUE |
Previous Message | Bruce Momjian | 2001-10-29 19:27:27 | Re: NULLs and sort order |