Re: [patch] ALTER RENAME and indexes

From: Brent Verner <brent(at)rcfile(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] ALTER RENAME and indexes
Date: 2001-10-09 00:18:47
Message-ID: 20011008201847.A7672@rcfile.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08 Oct 2001 at 14:43 (-0400), Tom Lane wrote:
| Brent Verner <brent(at)rcfile(dot)org> writes:
| > wooohoo!!! Of course, it would be best if someone else looked this
| > code over, because I get the feeling there is an easier way to get
| > this done.
|
| No, that's about right, except that you forgot one step: you shouldn't
| try to update column names of functional indexes, since their columns
| are named after the function not the column. If the function name
| happened to match the column name then you'd have applied an erroneous
| renaming.
|
| Fixed and applied to CVS.

Thanks for fixing that problem. Out of curiousity, did you put that
code in the renameatt() function for any reason, or is it just a
style thing? (I ask in hopes of getting closer to submitting
code/patches that you'd not have to rewrite to apply ;-) )

Thanks.
Brent

--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KobayashiJunichi 2001-10-09 01:26:08 PL/pgSQL doc sample bug? (in 7.1.3)
Previous Message Serguei Mokhov 2001-10-08 23:38:14 Re: Place of PO files for NLS (was Re: [PATCHES] PG_DUMP NLS (Russian))