Skip site navigation (1) Skip section navigation (2)

Re: Fix DatabaseMetaDataTest in JDBC test suite

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rene Pijlman <rene(at)lab(dot)applinet(dot)nl>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Fix DatabaseMetaDataTest in JDBC test suite
Date: 2001-09-10 15:08:01
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-jdbcpgsql-patches
Patch applied.  Thanks.

> Attached is a patch that fixes DatabaseMetaDataTest in the JDBC
> driver's test suite. With previous patches applied, this reduces
> the number of failures of the test suite from 6 to 4. The patch
> fixes the test case itself, rather than the driver.
> Details:
> 1) The driver correctly provided DatabaseMetaData about the sort
> order of NULLs. This was confirmed by Peter Eisentraut on
> pgsql-hackers. I fixed the test to accept/require the current
> behaviour, and made it dependent on the backend version. See
> nullsAreSortedAtStart(), nullsAreSortedAtEnd(),
> nullsAreSortedHigh() and nullsAreSortedLow().
> 2) DatabaseMetaData.supportsOrderByUnrelated() correctly
> returned true (an ORDER BY clause can contain columns that are
> not in the SELECT clause), but the test case required false.
> Fixed that.
> 3) Replaced deprecated assert() of junit.framework.TestCase by
> assertEquals(), assertTrue() and assertNotNull(). This is
> because assert will be a new keyword in Java 1.4.
> 4) Replaced assert(message,false) by the more elegant
> fail(message).
> Regards,
> Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>

[ Attachment, skipping... ]

> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-09-10 15:15:04
Subject: Re: Add relid to TD in plpython
Previous:From: Bruce MomjianDate: 2001-09-10 15:07:10
Subject: Re: Patch to add bytea support to JDBC

pgsql-jdbc by date

Next:From: Jeroen van VianenDate: 2001-09-10 18:00:39
Subject: Fix for broken JDBC's getColumn() (take 2)
Previous:From: Bruce MomjianDate: 2001-09-10 15:07:10
Subject: Re: Patch to add bytea support to JDBC

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group