Re: [HACKERS] JDBC pg_description update needed for CVS tip

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rene Pijlman <rene(at)lab(dot)applinet(dot)nl>
Cc: pgsql-patches(at)postgresql(dot)org, Barry Lind <barry(at)xythos(dot)com>, pgsql-jdbc(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jeroen(dot)van(dot)vianen(at)satama(dot)com
Subject: Re: [HACKERS] JDBC pg_description update needed for CVS tip
Date: 2001-09-09 01:15:54
Message-ID: 200109090115.f891Fse25381@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc pgsql-patches


Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> On Fri, 07 Sep 2001 01:34:46 -0400, Tom Lane wrote:
> >there is still an unpatched reference to pg_description in
> >getColumns(), in both jdbc1 and jdbc2.
>
> This was introduced by Jeroen's patch (see
> http://fts.postgresql.org/db/mw/msg.html?mid=1032468). Attached
> is a patch that returns getColumns() to using "select
> obj_description()" instead of direct access to pg_description,
> as per the request by Tom.
>
> I've incorporated Jeroen's fix to left outer join with
> pg_attrdef instead of inner join, so getColumns() also returns
> columns without a default value.
>
> I have, however, not included Jeroen's attempt to combine
> multiple queries into one huge multi-join query for better
> performance, because:
> 1) I don't know how to do that using obj_description() instead
> of direct access to pg_description
> 2) I don't think a performance improvement (if any) in this
> method is very important
>
> Because of the outer join, getColumns() will only work with a
> backend >= 7.1. Since the conditional coding for 7.1/7.2 and
> jdbc1/jdbc2 is already giving me headaches I didn't pursue a
> pre-7.1 solution.
>
> Regards,
> Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Varela Santoalla 2001-09-09 02:01:19 DBBalancer 0.3.0: Connection pòoling and load balancing for PostgreSQL
Previous Message Tatsuo Ishii 2001-09-08 23:27:39 Re: [PATCHES] CURRENT CVS: MULTIBYTE: CANT CONNECT....

Browse pgsql-jdbc by date

  From Date Subject
Next Message Rene Pijlman 2001-09-09 07:38:53 Re: getBlob problems with bytea type columns
Previous Message Bruce Momjian 2001-09-09 01:10:12 Re: Fix JDBC test suite, set/get transaction isolation level

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-09-09 03:08:46 Re: attribute names & typecast/psql default port
Previous Message Bruce Momjian 2001-09-09 01:10:12 Re: Fix JDBC test suite, set/get transaction isolation level