From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Rene Pijlman <rene(at)lab(dot)applinet(dot)nl> |
Cc: | ian(at)labfire(dot)com, pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: jdbc ResultSetMetaData::isWritable() |
Date: | 2001-09-06 18:26:49 |
Message-ID: | 200109061826.f86IQnl10236@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Well, if it is that easy, I can do it. Patch attached and applied.
> On Mon, 3 Sep 2001 22:01:17 -0500, you wrote:
> >public boolean isWritable(int column) throws SQLException
> >{
> > if (isReadOnly(column))
> > return true;
> > else
> > return false;
> >}
>
> The author probably intended:
>
> public boolean isWritable(int column) throws SQLException
> {
> return !isReadOnly(column);
> }
>
> And if he would have coded it this way he wouldn't have made
> this mistake :-)
>
> >hence, isWritable() will always return false. this is something
> >of a problem :)
>
> Why exactly? In a way, true is just as incorrect as false, and
> perhaps it should throw "not implemented". But I guess that
> would be too non-backwardly-compatible.
>
> >let me know if i can provide further information.
>
> Will you submit a patch?
>
> Regards,
> Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Attachment | Content-Type | Size |
---|---|---|
unknown_filename | text/plain | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | T.R.Missner | 2001-09-06 18:28:49 | Re: error - NOTICE: current transaction...MORE DETAIL... |
Previous Message | Rene Pijlman | 2001-09-06 18:00:16 | Re: jdbc ResultSetMetaData::isWritable() |