Re: [PATCHES] Patch for jdbc2 ResultSet.java

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Joseph Shraibman <jks(at)selectacast(dot)net>
Cc: Barry Lind <barry(at)xythos(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-jdbc(at)postgresql(dot)org
Subject: Re: [PATCHES] Patch for jdbc2 ResultSet.java
Date: 2001-09-06 03:32:33
Message-ID: 200109060332.f863WXH12241@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches

>
>
> Barry Lind wrote:
> > Joseph,
> >
> > In looking at this patch it looks OK, except for the following change:
> >
> > > ! if (index>=-rows.size())
> > > --- 725,737 ----
> > > ! if (index > rows_size)
> >
> > I haven't looked at the entire method, but the change you made seems
> > incorrect.
> >
> Oops! Thanks for catching that. Cut and paste error. I hate those.
>
> > If you want this patch to be applied it should be sent to the
> > pgsql-patches mail list.
>
>
> I thought that jdbc stuff was preferred to be on the jdbc list. I guess not.

Actually, yes, I throw stuff to jdbc and patches for completeness. jdbc
people, tell me what you want done in the future.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Tom Lane 2001-09-06 03:41:30 JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
Previous Message Bruce Momjian 2001-09-06 03:31:42 Re: Re: Proposal to fix Statement.executeBatch()

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-09-06 03:41:30 JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
Previous Message Bruce Momjian 2001-09-06 03:23:38 Re: PAM Authentication Patch, take one...