Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Vsevolod Lobko <seva(at)sevasoft(dot)kiev(dot)ua>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal
Date: 2001-09-06 02:56:42
Message-ID: 200109060256.f862ugm03426@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Thanks for this patch. It is something we really needed.

> Next version of patch.
> Now with documentation update and disabling of UTF conversion for Tcl <=8.0
>
> On Fri, 24 Aug 2001, Vsevolod Lobko wrote:
>
> > On Thu, 23 Aug 2001, Tom Lane wrote:
> >
> > > > Is this looks better?
> > >
> > > It does, but one small gripe: the lack of semicolons will probably cause
> > > pg_indent to mess up the indentation. (I know emacs' autoindent mode
> > > will not work nicely with it, either.) Please set up the macros so that
> > > you write
> > >
> > > UTF_BEGIN;
> > > Tcl_DStringAppend(&unknown_src, UTF_E2U(part), -1);
> > > UTF_END;
> > >
> > > and then I'll be happy.
> >
> > Attached revised patch
> >
> > > Your point about overhead is a good one, so I retract the gripe about
> > > using a configure switch. But please include documentation patches to
> > > describe the configure option in the administrator's guide (installation
> > > section).
> >
> > This patch still uses configure switch for enabling feature.
> >
> > For enabling based on tcl version we have 2 posibilites:
> > 1) having feature enabled by default, but in pltcl.c check for tcl
> > version and disable it for old versions
> > 2) enable or disable at configure time based on tcl version, but there
> > are problem - current configure don't checks for tcl version at all
> > and my configure skills not enought for adding this
> >

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Harkness 2001-09-06 02:57:00 Re: Patch for jdbc2 ResultSet.java
Previous Message Bruce Momjian 2001-09-06 02:54:34 Re: libpgtcl.dll