Re: build fixes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Liam Stewart <liams(at)redhat(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: build fixes
Date: 2001-08-21 17:14:03
Message-ID: 200108211714.f7LHE3e23435@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> Liam Stewart writes:
>
> > Here is a patch that fixes a couple of dumb bugs that cause builds to
> > fail.
>
> > snprintf(PQerrormsg, PQERRORMSG_LENGTH,
> > ! "ident_unix: unknown local user with uid %d\n"),
> > fputs(PQerrormsg, stderr);
>
> We generally put semicolons at the end in C. ;-)

Yea, I guess so. :-) Actually, we needed a uid parameter which I added
too.

>
> > /* descriptor items */
> > enum ECPGdtype
> > {
> > ! ECPGd_count = 1,
> > ECPGd_data,
> > ECPGd_di_code,
> > ECPGd_di_precision,
> > --- 52,59 ----
> > /* descriptor items */
> > enum ECPGdtype
> > {
> > ! ECPGd_cardinality = 1,
> > ! ECPGd_count,
> > ECPGd_data,
> > ECPGd_di_code,
> > ECPGd_di_precision,
>
> Put it at the end unless you want to deal with binary incompatibilities.

Done.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Zoller 2001-08-21 20:12:20 Array Support Fix
Previous Message Bruce Momjian 2001-08-21 17:13:19 Re: build fixes