Re: build fixes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Liam Stewart <liams(at)redhat(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: build fixes
Date: 2001-08-21 14:47:41
Message-ID: 200108211447.f7LElf429676@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

>
> Here is a patch that fixes a couple of dumb bugs that cause builds to
> fail.
>
> Liam
>
> --
> Liam Stewart :: Red Hat Canada, Ltd. :: liams(at)redhat(dot)com

OK, I fixed the first one with:

snprintf(PQerrormsg, PQERRORMSG_LENGTH,
"ident_unix: unknown local user with uid %d\n", peercred.uid);
^^^^^^^^^^^^^^^

I missed that one because I don't have SO_PEERCRED here.

In the following patch, is it correct to make ECPGd_cardinality = 1 or
should it be put at the end of the list?

Index: src/interfaces/ecpg/include/ecpgtype.h
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/interfaces/ecpg/include/ecpgtype.h,v
retrieving revision 1.18
diff -c -r1.18 ecpgtype.h
*** src/interfaces/ecpg/include/ecpgtype.h 2001/03/29 09:59:00 1.18
--- src/interfaces/ecpg/include/ecpgtype.h 2001/08/21 13:54:47
***************
*** 52,58 ****
/* descriptor items */
enum ECPGdtype
{
! ECPGd_count = 1,
ECPGd_data,
ECPGd_di_code,
ECPGd_di_precision,
--- 52,59 ----
/* descriptor items */
enum ECPGdtype
{
! ECPGd_cardinality = 1,
! ECPGd_count,
ECPGd_data,
ECPGd_di_code,
ECPGd_di_precision,

--yrj/dFKFPuw6o+aM
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

--yrj/dFKFPuw6o+aM--

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Liam Stewart 2001-08-21 14:58:46 Re: build fixes
Previous Message Tom Lane 2001-08-21 14:15:30 Re: [Fwd: Re: New EXPLAIN ANALYZE statement]