Re: Re: WIN32 errno patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Mikhail Terekhov <terekhov(at)emc(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: WIN32 errno patch
Date: 2001-08-09 19:40:16
Message-ID: 200108091940.f79JeG313168@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches


Tom has applied these changes to the CVS snapshot. Can you try it and
let us know.

> One can't just #undef errno on windows because it is defined as follows:
>
>
> #if defined(_MT) || defined(_DLL)
> extern int * __cdecl _errno(void);
> #define errno (*_errno())
> #else /* ndef _MT && ndef _DLL */
> extern int errno;
> #endif /* _MT || _DLL */
>
> So when building a dll or a multithreaded application it is not a plain
> variable but call to the _errno() and after #undef errno one will lose
> errno completely. For the same reason it is impossible to use something
> like 'errno=0;'.
>
> Mikhail Terekhov
>
>
> Tom Lane wrote:
> >
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > Any idea where we are on this?
> >
> > I'm planning to #undef errno around the three routines that need to get
> > at plain errno. Not done yet though...
> >
> > regards, tom lane
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2001-08-09 19:46:13 Re: pgsql/src include/access/Tag: include/access/R ...
Previous Message Hiroshi Inoue 2001-08-09 19:22:24 pgsql/src include/access/Tag: include/access/R ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-08-09 20:26:41 Re: Re: WIN32 errno patch
Previous Message Peter Eisentraut 2001-08-09 19:15:02 Creating tables with unknown type columns

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-08-09 20:26:41 Re: Re: WIN32 errno patch
Previous Message Mikhail Terekhov 2001-08-09 19:08:12 Re: Re: WIN32 errno patch