Re: Current cvs does not compile jdbc1 driver

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: dave(at)fastcrypt(dot)com
Cc: PostgreSQL jdbc list <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Current cvs does not compile jdbc1 driver
Date: 2001-08-04 19:46:33
Message-ID: 200108041946.f74JkYH17538@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc


The supplied patch did not apply to current CVS. I found the
appropriate lines and made the change. Patch attached.

> Bruce,
>
> Sorry wrong cvs option
>
> What is your environment? I think you are using jdk 1.2, no? The problem
> is that in jdk1.1? There is no Properties.setProperty
> If you are using jdk1.2 then it will compile fine. The following patch
> works with all of the compilers
>
> Dave
>
>
> Index: Connection.java
> ===================================================================
> RCS file:
> /home/projects/pgsql/cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/Co
> nnection.java,v
> retrieving revision 1.21
> diff -c -r1.21 Connection.java
> *** Connection.java 2001/07/30 14:51:19 1.21
> --- Connection.java 2001/08/03 16:27:26
> ***************
> *** 1036,1043 ****
> if(catalog!=null && !catalog.equals(PG_DATABASE)) {
> close();
> Properties info=new Properties();
> ! info.setProperty("user", PG_USER);
> ! info.setProperty("password", PG_PASSWORD);
> openConnection(PG_HOST, PG_PORT, info, catalog, this_url,
> this_driver);
> }
> }
> --- 1036,1043 ----
> if(catalog!=null && !catalog.equals(PG_DATABASE)) {
> close();
> Properties info=new Properties();
> ! info.put("user", PG_USER);
> ! info.put("password", PG_PASSWORD);
> openConnection(PG_HOST, PG_PORT, info, catalog, this_url,
> this_driver);
> }
> }
>
>
> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: August 3, 2001 12:22 PM
> To: dave(at)fastcrypt(dot)com
> Cc: pgsql-jdbc(at)postgresql(dot)org
> Subject: Re: Current cvs does not compile jdbc1 driver
>
>
>
> I am confused. It compiles here. I don't understand this patch either.
> Can you send a context diff?
>
> > Here is a quick hack to get it to compile properly
> >
> > Index: Connection.java
> > ===================================================================
> > RCS file:
> > /home/projects/pgsql/cvsroot/pgsql/src/interfaces/jdbc/org/postgresql/
> > Co
> > nnection.java,v
> > retrieving revision 1.21
> > diff -f -r1.21 Connection.java
> > c1039 1040
> > info.put("user", PG_USER);
> > info.put("password", PG_PASSWORD);
> >
> >
> >
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania
> 19026
>
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 868 bytes

Browse pgsql-jdbc by date

  From Date Subject
Next Message raviG 2001-08-05 14:08:16 Retrieving field of type bigint[]
Previous Message Bruce Momjian 2001-08-04 19:31:48 Re: Patch to improve commit time performance and a few other things