Re: Patch for Improved Syntax Error Reporting

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Padgett <npadgett(at)redhat(dot)com>, "pgsql-patches(at)postgresql(dot)org" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch for Improved Syntax Error Reporting
Date: 2001-08-01 20:10:05
Message-ID: 200108012010.f71KA5d13134@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > In fact, their solution is an improvement over what is in
> > TODO.detail/yacc now.
>
> Agreed, the idea of pulling out just the one line is an improvement over
> the last patch. It's still going down the wrong path though. We should
> be empowering client apps to highlight syntax errors properly, not
> presenting edited info in a way that might be useful to humans but will
> be unintelligible to programs. If we go that route, it will be harder
> to do the right thing later.
>
> > I know some people like a client-independent way of displaying errors,
> > but I like the direct approach of this patch, returning a string with
> > the error line highlighted and the location marked. I don't want to
> > push added complexity into the client, especially when we don't even
> > have a client who has this need yet.
>
> pgAdmin, phpAdmin, pgaccess, and friends don't count? We have GUI front
> ends *today*, you know.

But how do they display error messages now? Can't they just continue
doing that with this new code? Do we want to make them code their own
error handling, and for what little benefit? Let them figure out how to
display the error in fixed-width font and be done with it. I am sure
they have bigger things to do than colorize error locations.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2001-08-01 20:11:44 RE: What needs to be done?
Previous Message Bruce Momjian 2001-08-01 20:05:37 Re: OID wraparound: summary and proposal

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-08-01 20:23:11 Re: Revised Patch to allow multiple table locks in "Unison"
Previous Message Neil Padgett 2001-08-01 19:59:12 Re: Revised Patch to allow multiple table locks in "Unison"