Re: pgsql/src/interfaces/libpq fe-connect.c fe-exe ...h

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/interfaces/libpq fe-connect.c fe-exe ...h
Date: 2001-07-20 21:08:39
Message-ID: 200107202108.f6KL8dX17906@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> Bruce Momjian - CVS <momjian(at)hub(dot)org> writes:
> > Log message:
> > i've spotted a following problem using DBD::Pg under win32. winsock
> > functions do not set errno, so some normal conditions are treated as
> > fatal errors. e.g. fetching large tuples fails, as at some point recv()
> > returns EWOULDBLOCK. here's a patch, which replaces errno with
> > WSAGetLastError(). i've tried to to affect non-win32 code.
>
> I thought this was awaiting a merged patch from both submitters?
>
> Certainly I haven't reviewed it, since I thought that we were not
> going to apply it until that happened.

The other maintainer said this patch was better. He wants a few lines
of his patch added as well and he will send that over soon. You want to
see the applied patch or have it backed out?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2001-07-20 21:25:45 Re: [BUGS] WIN32 Non Blocking
Previous Message Bruce Momjian - CVS 2001-07-20 20:51:32 pgsql/doc TODO