Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se>
Cc: pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Date: 2001-07-15 04:29:48
Message-ID: 200107150429.f6F4TmN04288@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches


I am having trouble applying this patch to the current CVS tree. The
majority of changes fail to apply. Can you give me a patch against
current CVS or can someone manually merge the changes into CVS and send
me a patch? Thanks.

> On Thu, 12 Jul 2001, Bruce Momjian wrote:
>
> > Your patch has been added to the PostgreSQL unapplied patches list at:
>
> Here is a new version of that patch, with improvements from some feedback
> I got from Barry Lind.
> More of the encoding-related logic is moved into the Encoding class and
> I've added som clarifying comments.
>
> /Anders
>
> > > With this patch I've done an attempt to make the handling of character
> > > encoding in the JDBC driver a little clearer.
> > >
> > > * Cleans up the logic to select a JVM encoding for a backend encoding.
> > > * Makes the connection setup code easier to read.
> > > * Gathers character encoding and decoding in a single place.
> > > * Adds unit tests for encoding.
> > > * Introduces a new class, org.postgresql.core.Encoding, and the
> > > corresponding unit test class, org.postgresql.test.jdbc2.EncodingTest.
>
>
> _____________________________________________________________________
> A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
> Stockholm, Sweden

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message jason 2001-07-15 22:49:58 RE: Connection.setCatalog()
Previous Message Bruce Momjian 2001-07-15 04:21:21 Re: Patch for handling long null terminated strings in JDBC driver

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-07-16 05:20:01 Re: Patch to add support for partial indices
Previous Message Bruce Momjian 2001-07-15 04:26:19 Re: Patch to add support for partial indices