Re: patch for spelling mistake

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch for spelling mistake
Date: 2001-07-11 00:58:30
Message-ID: 200107110058.f6B0wUa23680@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> nconway(at)klamath(dot)dyndns(dot)org (Neil Conway) writes:
> > I think I made the patch properly; from the root of the 'pgsql'
> > CVS module, apply with: patch -p0 < patchfile.
>
> diff -c output is preferred. A plain diff such as you have here has too
> little context to be safe to apply (if someone else has edited the file
> since the version you diffed from, a plain diff patch is much too likely
> to be applied incorrectly).

Tom is right, diff -c is best, though in the patch you applied, there is
no chance for error so I can accept it. You have unique previous text
for each change.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-07-11 01:01:48 Re: 2 gig file size limit
Previous Message Bruce Momjian 2001-07-10 23:36:06 Re: Re: Time to read pg_hba.conf (Re: [PATCHES] [PATCH] Patch to make...)