Re: Re: [HACKERS] Outstanding patches

Can this patch be resubmitted with a postive-only return value?

> > + /* I use CMD_UPDATE, because no CMD_MOVE or the like
> > + exists, and I would like to provide the same
> > + kind of info as CMD_UPDATE */
> > + UpdateCommandInfo(CMD_UPDATE, 0, -1*estate->es_processed);
>
> I do not think it is a good idea to return a negative count for a
> backwards move; that is too likely to break client code that parses
> command result strings and isn't expecting minus signs. The client
> should know whether he issued MOVE FORWARD or MOVE BACKWARDS anyway,
> so just returning es_processed ought to be sufficient.
>
> Otherwise I think the patch is probably OK.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026