| From: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PQsetdbLogin bug? |
| Date: | 2001-05-28 04:36:23 |
| Message-ID: | 20010528133623S.t-ishii@sra.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> writes:
> > 2) check if the status of handle returned PQsetdbLogin is
> > CONNECTION_BAD closePGconn. if so, do not call pqPuts (and
> > pqFlush)
>
> I like this approach. The other way, you'd have to be sure that all
> failure paths close the socket before returning; even if you get it
> right today, somebody will break it again in future. The sending of
> the final 'X' is really quite optional anyhow, so I'd say it's fine
> not to do it when there's any question about whether it's safe.
done.
--
Tatsuo Ishii
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joe Conway | 2001-05-28 05:02:17 | remote database queries |
| Previous Message | pgsql-interfaces | 2001-05-28 02:22:03 | libpq++ in Apache Problem. |