From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix for tablename in targetlist |
Date: | 2001-05-20 04:35:25 |
Message-ID: | 200105200435.f4K4ZPO12981@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > In fact, I was
> > right that you have to call transformTargetEntry() -> transformExpr() ->
> > transformIdent() to get isRel set, and I have to do the longer fix.
>
> Yes, I would think that you should do transformTargetEntry() first and
> then look to see if you have an Ident w/ isRel set. The initial patch
> was OK because it happened after that transformation.
Yes, and you can't do that later because you need to add to the target
list. Calling transformTargetEntry returns a Resdom, which I don't
think I can tell if that is a rel or not, and it mucks up
pstate->p_last_resno++. I will show the patch on the patches list. It
does things similar to what happens above in that function.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | John Reid | 2001-05-20 04:44:32 | Re: possible DOMAIN implementation |
Previous Message | Tom Lane | 2001-05-20 04:31:07 | Re: Functions returning sets |