Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>, Pgsql-Cygwin <pgsql-cygwin(at)postgresql(dot)org>, Michael Lemke <lemkemch(at)t-online(dot)de>
Subject: Re: [PATCHES] Cygwin PostgreSQL ESQL Patch
Date: 2001-04-20 19:38:56
Message-ID: 20010420153856.A169@dothill.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-patches

On Fri, Apr 20, 2001 at 02:38:53PM -0400, Tom Lane wrote:
> Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
> > In the above mentioned URL, I suggested including c.h as another
> > possibly better solution. However, I saw the following in ecpglib.h:
> > /*
> > * this is a small part of c.h since we don't want to leak all postgres
> > * definitions into ecpg programs
> > */
> > so I decided against including c.h in the first version of my patch.
>
> That's a fair point. Maybe it should be
>
> +#ifndef DLLIMPORT
> +#ifdef __CYGWIN__
> +#define DLLIMPORT __declspec (dllimport)
> +#else
> +#define DLLIMPORT
> +#endif /* __CYGWIN__ */
> +#endif /* DLLIMPORT */

I will redo my patch with the modification suggested above.

Thanks,
Jason

--
Jason Tishler
Director, Software Engineering Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp. Fax: +1 (732) 264-8798
82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA WWW: http://www.dothill.com

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Matthieu Guyonnet-Duluc 2001-04-22 20:04:09 connect on cygwin - v7.0
Previous Message Tom Lane 2001-04-20 18:38:53 Re: [PATCHES] Cygwin PostgreSQL ESQL Patch

Browse pgsql-patches by date

  From Date Subject
Next Message Thorsten Mauch 2001-04-22 22:05:54 Support for JDBC Binary type
Previous Message Tom Lane 2001-04-20 18:38:53 Re: [PATCHES] Cygwin PostgreSQL ESQL Patch