Re: CURRENT/OLD keywords still broken

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CURRENT/OLD keywords still broken
Date: 2000-12-15 23:36:32
Message-ID: 200012152336.SAA09486@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

OK, compatibility mapping removed.

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > That was me. The old code did old -> current, so I changed it to do
> > current -> old. How else can I fix this? Attached is the old patch.
>
> But CURRENT was strictly an internal token name, not a string the user
> could actually see. So there's no need to have
> + /* for portability with old rules bjm 2000-06-12 */
> + {"current", OLD},
>
> The only way that there would be a compatibility problem would be if
> ruleutils.c had been set up to print CURRENT, but it wasn't:
>
> *** 1278,1284 ****
> quote_identifier(rte->relname));
> else if (!strcmp(rte->ref->relname, "*NEW*"))
> appendStringInfo(buf, "new.");
> ! else if (!strcmp(rte->ref->relname, "*CURRENT*"))
> appendStringInfo(buf, "old.");
> else
> appendStringInfo(buf, "%s.",
> --- 1278,1284 ----
> quote_identifier(rte->relname));
> else if (!strcmp(rte->ref->relname, "*NEW*"))
> appendStringInfo(buf, "new.");
> ! else if (!strcmp(rte->ref->relname, "*OLD*"))
> appendStringInfo(buf, "old.");
> else
>
> NEW and OLD are what the user see, and have been for awhile. So there's
> no compatibility issue here.
>
> regards, tom lane
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2000-12-15 23:39:22 Re: CURRENT/OLD keywords still broken
Previous Message Oliver Elphick 2000-12-15 23:31:41 Re: 7.1 (current) unwanted NOT NULL constraint inserted