Re: Idea for reducing planning time

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: Alfred Perlstein <bright(at)wintelcom(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Idea for reducing planning time
Date: 2000-12-15 18:34:26
Message-ID: 200012151834.NAA22424@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> sorry, meant to respond to the original and deleted it too fast ...
>
> Tom, if the difference between 7.0 and 7.1 is such that there is a
> performance decrease, *please* apply the fix ... with the boon that OUTER
> JOINs will provide, would hate to see us with a performance hit reducing
> that impact ...
>
> One thing I would like to suggest for this stage of the beta, though, is
> that a little 'peer review' before committing the code might be something
> that would help 'ease' implementing stuff like this and Vadim's VACUUM
> code ... read through Vadim's code and see if it looks okay to you ... get
> Vadim to read through your code/patch and see if it looks okay to him
> ... it adds a day or two to the commit cycle, but at least you can say it
> was reviewed before committed ...
>

Totally agree. In the old days, we posted all our patches to the list
so people could see. We used to make cvs commits only on the main
server, so we had the patch handy, and it made sense to post it. Now
that we have remote cvs, we don't do it as much, but in this case, cvs
diff -c is a big help.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oliver Elphick 2000-12-15 18:43:01 7.1 (current) unwanted NOT NULL constraint inserted (more)
Previous Message Bruce Momjian 2000-12-15 18:32:05 Re: Idea for reducing planning time