Re: current is broken

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: current is broken
Date: 2000-09-13 04:56:46
Message-ID: 20000913135646X.t-ishii@sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I just fixed one of these in the backend --- looks like someone was
> testing with a C++ compiler instead of an ANSI-C-compliant compiler.
> Need to put the 'int len;' declaration at the top of the function.

Ok.

> > pg_dump.c:268: warning: implicit declaration of function `pg_mbcliplen'
>
> > Moreover, pg_mbcliplen cannot be used in frontend.
>
> Ooops. I guess libpq needs to supply a copy of this function?

Simply copying the function won't work since the way to know what
encoding is used for this session is different between backend and
frontend.

Even better idea would be creating a new function that returns the
actual rule name (after being shorten) from given view name. I don't
think it's a good idea to have codes to get an actual rule name in two
separate places.
--
Tatsuo Ishii

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-09-13 05:02:51 Re: current is broken
Previous Message Tom Lane 2000-09-13 04:35:15 Re: current is broken