Re: to_char's ISO week

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>, pgsql-patches <pgsql-patches(at)postgreSQL(dot)org>
Subject: Re: to_char's ISO week
Date: 2000-08-29 04:43:06
Message-ID: 200008290443.AAA13445@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Applied, except for the following. The C files had 'return 0' and I
left those unchanged.

---------------------------------------------------------------------------

***************
*** 38,55 ****
to_ascii_encname(PG_FUNCTION_ARGS)
{
multibyte_error();
}

Datum
to_ascii_enc(PG_FUNCTION_ARGS)
{
multibyte_error();
}

Datum
to_ascii_default(PG_FUNCTION_ARGS)
{
multibyte_error();
}


--- 38,58 ----
to_ascii_encname(PG_FUNCTION_ARGS)
{
multibyte_error();
+ return (Datum) NULL;
}

Datum
to_ascii_enc(PG_FUNCTION_ARGS)
{
multibyte_error();
+ return (Datum) NULL;
}

Datum
to_ascii_default(PG_FUNCTION_ARGS)
{
multibyte_error();
+ return (Datum) NULL;
}


>
> * to_char:
>
> - full support for IW (ISO week) and vice versa conversion for IW too
> (the to_char 'week' support is now complete and I hope correct).
>
> Thomas, I use for IW code from timestamp.c, for this I create separate
> function date2isoweek() from original 'case DTK_WEEK:' code in the
> timestamp_part(). I mean will better use one code for same feature in
> date_part() and in to_char(). The isoweek2date() is added to timestamp.c
> too. Right?
>
> IMHO in 7.1 will all to_char's features complete. It is cca 41 templates
> for date/time and cca 21 for numbers.
>
> * to_ascii:
>
> - gcc, is it correct now? :-)
>
>
> In the patch is documentation for to_char's IW and for to_ascii().
>
> Karel
Content-Description:

[ application/x-gzip is not supported, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Karel Zak 2000-08-29 08:06:35 Re: to_char's ISO week
Previous Message Bruce Momjian 2000-08-29 04:21:13 Re: More FK constraint stuff