Re: to_ascii()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Karel Zak <zakkr(at)zf(dot)jcu(dot)cz>
Cc: pgsql-patches <pgsql-patches(at)postgreSQL(dot)org>
Subject: Re: to_ascii()
Date: 2000-08-05 15:52:03
Message-ID: 200008051552.LAA21999@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

>
> On Sat, 5 Aug 2000, Bruce Momjian wrote:
>
> > I see the following warnings in a gcc compile with -Wall:
> >
> > ascii.c: In function `to_ascii_encname':
> > ascii.c:41: warning: control reaches end of non-void function
> > ascii.c: In function `to_ascii_enc':
> > ascii.c:47: warning: control reaches end of non-void function
> > ascii.c: In function `to_ascii_default':
> > ascii.c:53: warning: control reaches end of non-void function
> >
>
> Grrr..... it's really bad day for me.
>
> Please, ignore this warning now. I will work on to_char() and this
> I resolve too. It's pedantic warning from a gcc, these functions
> always end with elog(ERROR..) and not with some return. But a gcc
> don't knows it :-(
>
> (or you can add "return (Datum) NULL;" to these three lines if you don't
> want wait for me next patch).
>

No problem. Just sent along when you are ready.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Karel Zak 2000-08-07 08:55:57 to_char's ISO week
Previous Message Karel Zak 2000-08-05 15:50:48 Re: to_ascii()