Re: [HACKERS] --enable-debug

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] --enable-debug
Date: 2000-01-26 06:04:12
Message-ID: 200001260604.BAA23774@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> Currently, I believe -Wall is turned on automatically if your compiler
> >> is gcc --- at least it seems to work that way on my platform (maybe
> >> it's in the hpux_gcc template?). Anyway I get a pretty good set of -W
> >> options without doing anything special.
>
> > I remember when we removed every warning gcc -Wall complained about.
>
> Um, did we stop?
>
> In my experience, gcc is an excellent detector of portability problems.
> I believe that it is good practice to crank gcc's warning level out
> to the max, and to fix everything that it complains about.
>

No, we fixed all the code gcc warned about. Our code is 100% clean.
The only problems are fork() handling, and patches people have submitted
that were not 100% clean and will be fixed before final.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2000-01-26 08:45:42 Re: Happy column adding (was RE: [HACKERS] Happy column dropping)
Previous Message Tom Lane 2000-01-26 06:01:40 Re: [HACKERS] --enable-debug