Re: [PATCH] Add pretty-printed XML output option

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Andrey Borodin <amborodin86(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: 2023-02-17 19:01:35
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 17.02.23 01:08, Andrey Borodin wrote:
> On Thu, Feb 16, 2023 at 2:12 PM Jim Jones<jim(dot)jones(at)uni-muenster(dot)de> wrote:
> I've looked into the patch. The code looks to conform to usual
> expectations.
> One nit: this comment should have just one asterisk.
> + /**

Thanks for reviewing! Asterisk removed in v14.

> And I have a dumb question: is this function protected from using
> external XML namespaces? What if the user passes some xmlns that will
> force it to read namespace data from the server filesystem? Or is it
> not possible? I see there are a lot of calls to xml_parse() anyway,
> but still...

According to the documentation,[1] such validations are not supported.

/"The |xml| type does not validate input values against a document type
declaration (DTD), even when the input value specifies a DTD. There is
also currently no built-in support for validating against other XML
schema languages such as XML Schema."/

But I'll have a look at the code to be sure :)

Best, Jim


Attachment Content-Type Size
v14-0001-Add-pretty-printed-XML-output-option.patch text/x-patch 28.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Floris Van Nee 2023-02-17 19:23:45 RE: pg_init_privs corruption.
Previous Message Jonathan S. Katz 2023-02-17 19:00:21 Re: The output sql generated by pg_dump for a create function refers to a modified table name