| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pkg-config Requires.private entries should be comma-separated |
| Date: | 2023-03-15 07:51:04 |
| Message-ID: | 1fb52d61-0964-2d8e-87d9-e8be830e2b24@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While comparing the .pc (pkg-config) files generated by the make and
meson builds, I noticed that the Requires.private entries use different
delimiters. The make build uses spaces, the meson build uses commas.
The pkg-config documentation says that it should be comma-separated, but
apparently about half the .pc in the wild use just spaces.
The pkg-config source code acknowledges that both commas and spaces work:
https://github.com/freedesktop/pkg-config/blob/master/parse.c#L273
https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286
I think for consistency we should change the make build to use commas
anyway. See attached patch.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pkg-config-Requires.private-entries-should-be-comma-.patch | text/plain | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-03-15 07:58:49 | Re: psql \watch 2nd argument: iteration count |
| Previous Message | Antonin Houska | 2023-03-15 07:42:10 | Re: Privileges on PUBLICATION |