Re: [pgScript patch] Improved test output + make use of pgAdmin UI for error output

From: Mickael Deloison <mdeloison(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgScript patch] Improved test output + make use of pgAdmin UI for error output
Date: 2009-03-12 13:56:13
Message-ID: 1f8f052b0903120656j581d2adco68601ad905dfecd0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

2009/3/11 Dave Page <dpage(at)pgadmin(dot)org>:
> On Wed, Mar 11, 2009 at 5:51 PM, Mickael Deloison <mdeloison(at)gmail(dot)com> wrote:
>> 2009/3/11 Dave Page <dpage(at)pgadmin(dot)org>:
>>> Testing on Windows, it fails the first tests I try :-(
>>>
>>> select * from missing_table
>>>
>>> I get no error message at all. If I enter garbage, I just get the following:
>>>
>>> 1.0: syntax error, unexpected character
>>
>> This is normal: you do not have anything in the output because the
>> query must be terminated with a semi-colon.
>> I will look at that and add an error message.
>
> Thanks - I think that would quickly become a gotcha otherwise!

Hi Dave,

Attached to this email, a patch that prints an error when statements
are not ended with a semi-colon or when the end of file in encountered
whereas a string is not ended. For example
SELECT 1
PRINT 'Hi
SELECT $A$ abc
SELECT 'Hi
All those statements return an error saying a semi-colon is expected.

Best regards,
Mickael

Attachment Content-Type Size
pgscript.patch application/octet-stream 9.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2009-03-12 14:37:35 SVN Commit by dpage: r7689 - in trunk/pgadmin3/pgadmin/include: dlg images
Previous Message Dave Page 2009-03-12 13:47:29 Re: pgadmin 1.8.4 freeze ?